Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hour to DATE_ADD and DATE_SUB #354

Merged
merged 4 commits into from
Aug 6, 2013
Merged

Conversation

makhov
Copy link

@makhov makhov commented Aug 6, 2013

Add getDateAddHourExpression and getDateSubHourExpression to use DATE_ADD and DATE_SUB in doctrine with hours.

@makhov
Copy link
Author

makhov commented Aug 6, 2013

Pull request to doctrine/doctrine2 — doctrine/orm#748

@Ocramius
Copy link
Member

Ocramius commented Aug 6, 2013

@makhov these are DATE_ADD_HOUR and DATE_SUB_HOURS, not DATE_ADD and DATE_SUB... Isn't there a more consistent way of adding dates in general?

@makhov
Copy link
Author

makhov commented Aug 6, 2013

@Ocramius sorry, what do you mean?

@guilhermeblanco
Copy link
Member

@Ocramius DATE_ADD and DATE_SUB are standardized to deal with date/time manipulation already.

guilhermeblanco added a commit that referenced this pull request Aug 6, 2013
Add hour to DATE_ADD and DATE_SUB
@guilhermeblanco guilhermeblanco merged commit b4d80ab into doctrine:master Aug 6, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants