Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for namespace/schema quoting if it is a reserved keyword. #357

Merged
merged 1 commit into from
Aug 9, 2013

Conversation

guilhermeblanco
Copy link
Member

No description provided.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-579

We use Jira to track the state of pull requests and the versions they got
included in.

guilhermeblanco added a commit that referenced this pull request Aug 9, 2013
Added support for namespace/schema quoting if it is a reserved keyword.
@guilhermeblanco guilhermeblanco merged commit f3756f8 into master Aug 9, 2013
@guilhermeblanco guilhermeblanco deleted the PgSqlSchemaFix branch August 9, 2013 02:36
@beberlei
Copy link
Member

beberlei commented Aug 9, 2013

@guilhermeblanco tests please

@deeky666
Copy link
Member

deeky666 commented Aug 9, 2013

@beberlei I think he reverted the patch in commit 9b44bc9

@guilhermeblanco
Copy link
Member Author

@beberlei @deeky666 It introduced another problem, so I reverted it.
It's quite hard to easily test on ORM side something on DBAL side without modifying composer, blah blah blah, etc... =
I may revisit this later. =)

@beberlei
Copy link
Member

@guilhermeblanco checkout orm with --prefer-source and work on the DBAL repository inside vendor.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants