Update PostgreSqlPlatform.php #378

merged 5 commits into from Dec 18, 2013

4 participants


Decimal column Update if precision or scale was changed

@birko birko Update PostgreSqlPlatform.php
Decimal column Update if precision or scale was changed


thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:


We use Jira to track the state of pull requests and the versions they got
included in.

Doctrine member

We have to check if this affects other platforms as well. Also a test would be great, but probably a bit difficult to setup.


Should I add the test in /Doctrine/Tests/DBAL/Platforms/AbstractPlatformTestCase.php ?
But who will fix then the other platorms then. I am Not skilled in every SQL ;)

Doctrine member

@birko @beberlei As far as I can see this doesn't affect the other platforms as they use the AbstractPlatform::getColumnDeclarationSQL method to generate the SQL for changed columns, no matter what has changed (only Sqlite seems to handle it differently but still doesn't seem to be affected by this).

Doctrine member

@birko Can you please provide a test for this?


Yes. I will add it soon. probably later today


sorry for so much commits. couldn't run the test localy

@beberlei beberlei merged commit c504375 into doctrine:master Dec 18, 2013

1 check passed

Details default The Travis CI build passed
@birko birko deleted the unknown repository branch Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment