Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PostgreSqlPlatform.php #378

Merged
merged 5 commits into from
Dec 18, 2013
Merged

Update PostgreSqlPlatform.php #378

merged 5 commits into from
Dec 18, 2013

Conversation

birko
Copy link
Contributor

@birko birko commented Sep 26, 2013

Decimal column Update if precision or scale was changed

Decimal column Update if precision or scale was changed
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-614

We use Jira to track the state of pull requests and the versions they got
included in.

@beberlei
Copy link
Member

We have to check if this affects other platforms as well. Also a test would be great, but probably a bit difficult to setup.

@birko
Copy link
Contributor Author

birko commented Sep 27, 2013

Should I add the test in /Doctrine/Tests/DBAL/Platforms/AbstractPlatformTestCase.php ?
But who will fix then the other platorms then. I am Not skilled in every SQL ;)

@deeky666
Copy link
Member

deeky666 commented Oct 9, 2013

@birko @beberlei As far as I can see this doesn't affect the other platforms as they use the AbstractPlatform::getColumnDeclarationSQL method to generate the SQL for changed columns, no matter what has changed (only Sqlite seems to handle it differently but still doesn't seem to be affected by this).

@deeky666
Copy link
Member

@birko Can you please provide a test for this?

@birko
Copy link
Contributor Author

birko commented Nov 18, 2013

Yes. I will add it soon. probably later today

@birko
Copy link
Contributor Author

birko commented Nov 20, 2013

sorry for so much commits. couldn't run the test localy

beberlei added a commit that referenced this pull request Dec 18, 2013
Update PostgreSqlPlatform.php
@beberlei beberlei merged commit c504375 into doctrine:master Dec 18, 2013
@birko birko deleted the patch-1 branch February 12, 2014 08:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants