[DBAL-592] Fix schema comparison with FK that contain quoted column names. #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
QuoteStrategy
decides to quote column names for FK, schema comparator (and in effect - schema tool), will be stuck in anALTER TABLE * DROP FOREIGN KEY
loop, because it doesn't recognise old indexes with matching column names.The problem lies inside Comparator, which relied on column names that might or might not be quoted (depending on platform, schema and dbal settings). The comparison must be performed on unquoted column names both ways, as it is already performed for normal indexes, table names and columns names.
Tests will come shortly.