Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExceptionConverterDriver #4129

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Remove ExceptionConverterDriver #4129

merged 1 commit into from
Jun 29, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 28, 2020

Q A
Type improvement
BC Break yes

See #4118.

@morozov morozov added this to the 3.0.0 milestone Jun 28, 2020
@morozov morozov force-pushed the remove-exception-converter-driver branch from 6ecf2bf to 53e5a09 Compare June 28, 2020 19:56
@morozov morozov requested a review from greg0ire June 28, 2020 20:17
@morozov morozov marked this pull request as draft June 28, 2020 23:54
@morozov morozov marked this pull request as ready for review June 28, 2020 23:56
@morozov
Copy link
Member Author

morozov commented Jun 29, 2020

@greg0ire after filing this PR, I realized that I want to go further and move the exception conversion logic into a separate interface that the driver would instantiate similarly to getDatabasePlatform(). The conversion logic is the biggest reason why we have abstract driver classes, so moving it out would be a good first step towards getting rid of the inheritance in drivers and turning them into thin facades (not sure if that's the right term though).

Implementing this will require some more cleanup of the driver exceptions which I'm currently working on, and it also depends on these changes as well.

What do you think if we merge this as is and rework in the next few days?

greg0ire
greg0ire approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@morozov morozov merged commit babdc32 into doctrine:3.0.x Jun 29, 2020
@morozov morozov deleted the remove-exception-converter-driver branch June 29, 2020 20:34
@morozov morozov self-assigned this Jun 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
BC Break Drivers Error Handling
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire