phpdoc in Table::addForeignKey() update #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-692 We use Jira to track the state of pull requests and the versions they got |
|
some other methods are also accepting `Table|string``, so they should also be fixed |
|
ok, 'll try to fix .You mean other methods of |
|
I mean other methods of this class |
|
Checked whole project, all |
beberlei
added a commit
that referenced
this pull request
Dec 13, 2013
phpdoc in Table::addForeignKey() update
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added significant typehint in PhpDoc:
$foreignTableparam inaddForeignKeyConstraint()can be just string name of table.It unobvious in IDE hinting and treated as wrong param. It even can confuse developer, forcing him use foreign keys additions only using existing tables. That was my case, for example 馃槙 Lost time till found out, that Table schema not necessary to exist for Foreign Key referring .