[DBAL-44] Fix column default value lifecycle #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-720 We use Jira to track the state of pull requests and the versions they got |
beberlei
added a commit
that referenced
this pull request
Dec 22, 2013
[DBAL-44] Fix column default value lifecycle
|
Can this go to 2.4 branch, or is it too large? Owncloud is carrying an earlier version / subset of this fix downstream: owncloud-archive/3rdparty@12d8399 we (Fedora) would be happy if we can get all of OC's downstream patches to DBAL merged into the 2.4 branch, then update our DBAL to 2.4 and have OC use it. |
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an approach to make the "lifecycle" of a column's default value more consistent and less error prone. It also fixes some platform implementations, especially when a column's default value has to be dropped (which requires an explicit drop clause on some vendors).
This implementation implies a default value of
nullas no default value set. All other values get evaluated as a default value.