[DBAL-44] Fix column default value lifecycle #456

Merged
merged 1 commit into from Dec 22, 2013

Projects

None yet

4 participants

@deeky666
Doctrine member

This is an approach to make the "lifecycle" of a column's default value more consistent and less error prone. It also fixes some platform implementations, especially when a column's default value has to be dropped (which requires an explicit drop clause on some vendors).
This implementation implies a default value of null as no default value set. All other values get evaluated as a default value.

@doctrinebot

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-720

We use Jira to track the state of pull requests and the versions they got
included in.

@beberlei beberlei merged commit 8fe7410 into doctrine:master Dec 22, 2013

1 check passed

Details default The Travis CI build passed
@AdamWill

Can this go to 2.4 branch, or is it too large? Owncloud is carrying an earlier version / subset of this fix downstream:

owncloud/3rdparty@12d8399

we (Fedora) would be happy if we can get all of OC's downstream patches to DBAL merged into the 2.4 branch, then update our DBAL to 2.4 and have OC use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment