Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4687] Deprecate Connection::lastInsertId($name) #4688

Merged
merged 1 commit into from
Jun 25, 2021
Merged

[GH-4687] Deprecate Connection::lastInsertId($name) #4688

merged 1 commit into from
Jun 25, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 23, 2021

Q A
Type improvement
BC Break no

Fixes #4687.

Apart from the issue in question, this change will reduce the scope and the number of breaking changes introduced in #4324.

@morozov morozov added this to the 3.2.0 milestone Jun 23, 2021
@morozov morozov requested a review from beberlei June 23, 2021 19:51
@morozov morozov merged commit c570c15 into doctrine:3.2.x Jun 25, 2021
@morozov morozov deleted the issues/4687 branch June 25, 2021 00:09
@morozov morozov mentioned this pull request Jul 18, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

@beberlei beberlei Awaiting requested review from beberlei

Assignees
No one assigned
Labels
Connections Deprecation PDO Sequences
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @SenseException