Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4687] Remove support for Connection::lastInsertId($name) #4691

Merged
merged 1 commit into from
Jun 26, 2021
Merged

[GH-4687] Remove support for Connection::lastInsertId($name) #4691

merged 1 commit into from
Jun 26, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 25, 2021

Q A
Type improvement
BC Break yes

Fixes #4687

@morozov morozov marked this pull request as ready for review June 25, 2021 22:31
@morozov morozov requested a review from greg0ire June 25, 2021 22:31
greg0ire
greg0ire approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too, coverage increase 🙂 (+0.39%)

@morozov morozov merged commit ca22fa3 into doctrine:4.0.x Jun 26, 2021
@morozov morozov deleted the issues/4687 branch June 26, 2021 14:21
@morozov morozov mentioned this pull request Jun 27, 2021
Merged
@morozov morozov linked an issue Jun 28, 2021 that may be closed by this pull request
Current sequence value should not be used for tracking last inserted ID #4687
Closed
@morozov morozov added this to the 4.0.0 milestone Jun 28, 2021
@morozov morozov mentioned this pull request Jul 18, 2021
Closed
@morozov morozov mentioned this pull request May 8, 2022
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
BC Break Connections PDO Sequences
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Current sequence value should not be used for tracking last inserted ID
2 participants
@morozov @greg0ire