Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a deprecation in console command return types #4970

Merged
merged 1 commit into from Nov 9, 2021

Conversation

javiereguiluz
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues -

Summary

This is needed to fix the following deprecation:

  1x: Method "Symfony\Component\Console\Command\Command::execute()" might add "int" as a native return type declaration in the future. Do the same in child class "Doctrine\DBAL\Tools\Console\Command\RunSqlCommand" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in AddUserCommandTest::testCreateUserNonInteractive from App\Tests\Command

@derrabus derrabus merged commit 9c8f2b0 into doctrine:2.13.x Nov 9, 2021
@derrabus
Copy link
Member

derrabus commented Nov 9, 2021

Thank you, @javiereguiluz!

@javiereguiluz javiereguiluz deleted the fix_deprecation branch November 9, 2021 11:37
@derrabus derrabus mentioned this pull request Nov 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants