Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symfony 6 #4977

Closed
wants to merge 1 commit into from
Closed

Support symfony 6 #4977

wants to merge 1 commit into from

Conversation

arvodia
Copy link

@arvodia arvodia commented Nov 9, 2021

Fixed

Q A
Type bug
BC Break no

Summary

Support symfony 6

@derrabus
Copy link
Member

derrabus commented Nov 9, 2021

This is a breaking change that we cannot apply to the 3.1.x branch. Apart from that, the command is compatible with Symfony 6 without adding this return type. Thanks for proposing, though.

@arvodia
Copy link
Author

arvodia commented Nov 9, 2021

in symfony 5.4+ you have to add the value of return otherwise you will see the depreciation message in the log
otherwise I will add in annotation the value of return ?

@derrabus
Copy link
Member

derrabus commented Nov 9, 2021

This has happened already, see #4970.

@arvodia
Copy link
Author

arvodia commented Nov 9, 2021

ok i m sorry
but why the commit is not applied?
you haven't yet emerged

@derrabus
Copy link
Member

derrabus commented Nov 9, 2021

We haven't tagged releases with that change yet. We will do so in time. This isn't really urgent, is it?

@arvodia
Copy link
Author

arvodia commented Nov 9, 2021

thank you for your reply
I will delete this post
I have already made a patch to have an empty log

@arvodia arvodia deleted the patch-1 branch November 9, 2021 22:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants