Fix JSON Dbal type to properly encode whole number float values, preserving zero fractions. #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erving zero fractions.
Ocramius
suggested changes
Jan 10, 2022
…back testJsonStringConvertsToPHPValue method.
Ocramius
previously approved these changes
Jan 10, 2022
derrabus
approved these changes
Jan 10, 2022
morozov
approved these changes
Jan 11, 2022
|
Thanks, @Kova101. |
|
@morozov is it worth cutting |
|
So far, it looks like the only issue solved in the milestone. I don't mind it being released if you need it that bad. But can't you temporarily override the class with a fixed one? |
|
Should be fine - it's just that I drop multiple releases a day, these days, so I'm used to closing a milestone as soon as it is complete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the zero fraction removal during JSON encoding. It is important for keeping the data integrity and really useful for strongly typed systems (value won't turn to integer during decode).