Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update docs regarding "datetimetz" type #6014

Merged
merged 1 commit into from Apr 25, 2024
Merged

[Docs] Update docs regarding "datetimetz" type #6014

merged 1 commit into from Apr 25, 2024

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Apr 16, 2023 •
edited

Q A
Type bug
Fixed issues n/a

Summary

Related to #6006.
BTW, I think we should rename known-vendor-issues.rst to something like vendor-specific-caveats.rst or similar, because many of the behaviors described there are not necessarily issues.

ToDo

@phansys phansys changed the title Add a note about the support and the behavior of the "datetimetz" type [Docs] Add a note about the support and the behavior of the "datetimetz" type Apr 16, 2023
@phansys phansys marked this pull request as ready for review April 16, 2023 21:01
@phansys phansys marked this pull request as draft April 16, 2023 21:38
@phansys phansys changed the title [Docs] Add a note about the support and the behavior of the "datetimetz" type [Docs] Update docs regarding `datetimetz" type Apr 17, 2023
@phansys phansys changed the title [Docs] Update docs regarding `datetimetz" type [Docs] Update docs regarding "datetimetz" type Apr 17, 2023
@phansys phansys changed the base branch from 3.7.x to 3.6.x April 17, 2023 02:41
@phansys phansys marked this pull request as ready for review April 17, 2023 02:45
@phansys phansys mentioned this pull request Apr 17, 2023
Closed
2 tasks
@phansys phansys mentioned this pull request Apr 17, 2023
Closed
7 tasks
@SenseException
Copy link
Member

Shouldn't this target 3.7.x too?

@phansys
Copy link
Contributor Author

phansys commented Apr 17, 2023

Shouldn't this target 3.7.x too?

At first sight, I think no, as it fixes some wrong assumptions.

@phansys phansys force-pushed the datetimetz branch 2 times, most recently from 78f2f5f to 27a2d8a Compare April 17, 2023 22:49
@phansys phansys mentioned this pull request Apr 19, 2023
Closed
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Jul 17, 2023
@phansys
Copy link
Contributor Author

phansys commented Jul 21, 2023

IMO, this is still relevant.

SenseException
SenseException previously approved these changes Jul 21, 2023
View reviewed changes
@github-actions github-actions bot removed the Stale label Jul 22, 2023
@derrabus derrabus changed the base branch from 3.6.x to 3.7.x September 26, 2023 21:52
@derrabus derrabus dismissed SenseException’s stale review September 26, 2023 21:52

The base branch was changed.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Dec 26, 2023
@greg0ire
Copy link
Member

@phansys can you please address the conflict? 🙏

@github-actions github-actions bot removed the Stale label Dec 29, 2023
@phansys
Copy link
Contributor Author

phansys commented Dec 29, 2023

I'm currently AFK, but I'll be rebasing today.
Thank you!

@derrabus derrabus changed the base branch from 3.7.x to 3.8.x January 25, 2024 22:55
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Apr 25, 2024
@derrabus derrabus removed the Stale label Apr 25, 2024
@derrabus derrabus added this to the 3.8.4 milestone Apr 25, 2024
@derrabus derrabus merged commit ad2fee0 into doctrine:3.8.x Apr 25, 2024
90 checks passed
derrabus added a commit to derrabus/dbal that referenced this pull request Apr 25, 2024
@derrabus
Merge branch '3.8.x' into 4.0.x
61d79c6 
* 3.8.x:
  Connection::setNestTransactionsWithSavepoints() should not break lazy connection (doctrine#6362)
  [Docs] Update docs regarding "datetimetz" type (doctrine#6014)
derrabus added a commit that referenced this pull request Apr 25, 2024
@derrabus
Merge branch '4.0.x' into 4.1.x
4ff0398 
* 4.0.x:
  Connection::setNestTransactionsWithSavepoints() should not break lazy connection (#6362)
  [Docs] Update docs regarding "datetimetz" type (#6014)
derrabus added a commit that referenced this pull request Apr 25, 2024
@derrabus
Merge branch '4.1.x' into 5.0.x
7cdec3f 
* 4.1.x:
  Connection::setNestTransactionsWithSavepoints() should not break lazy connection (#6362)
  [Docs] Update docs regarding "datetimetz" type (#6014)
@phansys phansys deleted the datetimetz branch April 25, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus derrabus approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
3.8.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phansys @SenseException @greg0ire @derrabus