Connection::setNestTransactionsWithSavepoints() should not break lazy connection #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Apr 19, 2024
derrabus
force-pushed
the
bugfix/lazy-savepoints
branch
from
b7a701d
to
abc4022
Compare
greg0ire
approved these changes
Apr 19, 2024
SenseException
approved these changes
Apr 24, 2024
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Apr 25, 2024
* 3.8.x: Connection::setNestTransactionsWithSavepoints() should not break lazy connection (doctrine#6362) [Docs] Update docs regarding "datetimetz" type (doctrine#6014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
Connection::setNestTransactionsWithSavepoints(), the platform is fetched to check if savepoints are actually supported. This is a problem because it might cause the connection to be opened.I've removed the check which will postpone the exception to the first time we attempt to create a savepoint.