Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisites for PHPUnit update to version 10 in 4.0.x #6066

Merged
merged 6 commits into from Jun 15, 2023

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 14, 2023

This is a backport of all relevant changes from #6065.

@morozov morozov added this to the 3.7.0 milestone Jun 14, 2023
@morozov morozov mentioned this pull request Jun 14, 2023
Using non-static methods as a data provider was deprecated in PHPUnit 10
The test should have been reworked within doctrine#3356.
PHPUnit 10 no longer ignores abstract classes that end with Test.
PHPUnit 10 does not allow data providers to throw any exceptions.
@morozov morozov marked this pull request as ready for review June 14, 2023 17:03
@derrabus derrabus merged commit e9b3de4 into doctrine:3.7.x Jun 15, 2023
70 checks passed
@derrabus
Copy link
Member

Great work, thank you!

@morozov morozov deleted the pre-phpunit-10 branch June 15, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants