Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPUnit to 10 #6065

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Update PHPUnit to 10 #6065

merged 4 commits into from
Jun 16, 2023

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 14, 2023

No description provided.

Using non-static methods as a data provider was deprecated in PHPUnit 10
See: sebastianbergmann/phpunit#5241

It covers a platform-specific use case in the base platform class,
which is pointless.
PHPUnit 10 no longer ignores abstract classes that end with Test.

Additionally, restore the concrete driver test classes which were
omitted during an earlier merge up from 3.x to 4.0.x. Instead of
mocking abstract driver classes, we will now test the concrete ones.
@morozov morozov marked this pull request as ready for review June 16, 2023 16:34
@morozov morozov added this to the 4.0.0-beta3 milestone Jun 16, 2023
@morozov morozov merged commit d069d3d into doctrine:4.0.x Jun 16, 2023
@morozov morozov deleted the phpunit-10 branch June 16, 2023 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants