Add deprecation layer and upgrade path for QueryBuilder::reset*() methods #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/query-builder-reset
branch
from
b996223
to
d00d45a
Compare
greg0ire
approved these changes
Oct 15, 2023
|
AppVeyor failure looks unrelated. |
morozov
approved these changes
Oct 15, 2023
|
Thanks @derrabus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing deprecation layer for the
QueryBuilder::resetQueryParts()andQueryBuilder::resetQueryPart()methods that had been removed from the 4.0.x branch already. Following the discussion in #6186 and the work done in #6190, some replacements have been put in place.