Bump dependencies to align with composer based installs #13311
Conversation
…SQLForSelect() method
mollux
force-pushed
the
bump-composer-packages
branch
from
6457771
to
b2799e4
Compare
mollux
force-pushed
the
bump-composer-packages
branch
from
b2799e4
to
be18187
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.0 #13311 +/- ##
============================================
- Coverage 58.63% 58.62% -0.01%
Complexity 32990 32990
============================================
Files 2183 2183
Lines 98758 98758
============================================
- Hits 57902 57901 -1
- Misses 40856 40857 +1 |
mollux
force-pushed
the
bump-composer-packages
branch
from
7476ca5
to
1981583
Compare
|
I ran the |
mollux
added
ready-to-test
|
Might be i'm a bit too conservative here. But wouldn't working the other way around actually make more sense? |
|
@mallezie I get your point, and I also thought about this. So for now, I see this as the middle ground, and will propose this to core team:
|
escopecz
added
bug
|
@mallezie do you agree with my POV on this issue? or do you see any blockers to merge this? |
|
No blockers to merging this from me. (Did not test anything). |
Description:
The current version of Composer dependencies are locked in the
composer.lockfile.There dependencies are used during development en when running the tests.
However, that lock file is not used when installing Mautic via composer, and that makes sense.
This means we need to ensure every on a regular basis that these dependencies are up-to-date.
This PR updates all(*) dependencies to the latest available version, and makes some changes to the tests to ensure they pass successfully.
2 packages have temporarily been locked more strictly, to ensure a version compatible with Mautic is used, as the composer based releases may experience a different outcome:
phpoffice/phpspreadsheetis restricted to^1.15 < 1.28, to ensure the data types of fields stay the same.In the tests some data changed from int|float to string, and this needs further investigation.
doctrine/dbalis restriced to^3.6.2 < 3.8.0, to ensure we don't need to change a lot of logic as some methods got deprecated.doctrine/dbal:^3.8.0is the rework ofQueryBuilder::getSQLForSelect(), seeEnable skipping locked rows in QueryBuilder doctrine/dbal#6191.
I already started to work on support for
3.8.0by adding a trait for to easily work with this in the tests, see app/bundles/CoreBundle/Test/Doctrine/MockedConnectionTrait.php.See the individual commits for more context.
Following table was generated using the ion-bazan/composer-diff Composer plugin, and running following command:
composer diff --no-dev -l.Steps to test this PR: