Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 3.8.x into 4.0.x #6268

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Merge 3.8.x into 4.0.x #6268

merged 3 commits into from
Jan 20, 2024

Conversation

derrabus
Copy link
Member

No description provided.

kitloong and others added 3 commits January 20, 2024 13:47
@kitloong
Keep NVARCHAR(MAX) length as -1 (doctrine#6251)
0febc80 
<!-- Fill in the relevant information below to help triage your pull
request. -->

|      Q       |   A
|------------- | -----------
| Type         | bug
| Fixed issues | doctrine#6038

#### Summary

As described in the mentioned issue, `-0.5` from `-1 / 2` will raise
type error when trying to `setLength`

```
Argument #1 ($length) must be of type ?int, float given
```

https://github.com/doctrine/dbal/blob/8bc0d9ae42f20af54120396ef7a1b3248479c2b5/src/Schema/Column.php#L78

This PR check if length is `-1` and keep it as is before perform
division.
@derrabus
Merge branch '3.7.x' into 3.8.x
fb222c5 
* 3.7.x:
  Keep NVARCHAR(MAX) length as -1 (doctrine#6251)
@derrabus
Merge branch '3.8.x' into 4.0.x
0a3df2e 
* 3.8.x:
  Keep NVARCHAR(MAX) length as -1 (doctrine#6251)
@greg0ire
Copy link
Member

greg0ire commented Jan 20, 2024 •
edited

Regarding the Appveyor build, I think cinst has to do with Chocolatey. But it looks like it has been removed: https://docs.chocolatey.org/en-us/choco/release-notes#breaking-changes

Fixed in #6269

@derrabus derrabus merged commit 0a3df2e into doctrine:4.0.x Jan 20, 2024
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Merge Up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derrabus @greg0ire @kitloong