New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using chocolatey shims #6269
Conversation
They have been removed in 2.0.0. See https://docs.chocolatey.org/en-us/guides/upgrading-to-chocolatey-v2-v6#chocolatey-shortcut-shims-removed
Ah there are more failures. Great!
That directory does not have 5.11.1, although it is advertised here: https://windows.php.net/downloads/pecl/releases/sqlsrv/ 🤔 |
I'm afraid Chocolatey didn't exist back then when I still worked with .NET and can't help here. Which version is in use? |
Oh I think I fixed the Chocolatey issue all right. But there is another, unrelated issue. Before this PR, had an issue with this line: Line 50 in 0febc80
Now it has an issue with this line: Line 73 in 0febc80
According to the history, the last working build was 8 hours ago. Looking at the logs, it worked because it reused a cache and did not have to go through the above commands. If that cache takes time to expire, that makes it easier to understand how we can have two issues and not just one. |
Let us try using the last version still available on windows.php.net A better fix should be to switch to https://github.com/Microsoft/msphpsql, but that will probably require a deeper rework of the build as it provides DLLs for PHP 8 and up.
I pushed a hotfix 🤢 It's ugly but at least we can know if we broke the Windows build or not. |
If by "ugly" you mean that now we have a hard-coded version, it's not the first time we are doing it. See #3484 for reference. This is totally acceptable. |
* 3.7.x: Stop using chocolatey shims (doctrine#6269)
* 3.8.x: Revert the rename column feature (doctrine#6276) fix: TableDiff deprecation points to wrong method (doctrine#6273) Stop using chocolatey shims (doctrine#6269) Add explicit renameColumn method for Table (doctrine#6080)
They have been removed in 2.0.0.
See https://docs.chocolatey.org/en-us/guides/upgrading-to-chocolatey-v2-v6#chocolatey-shortcut-shims-removed