Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using chocolatey shims #6269

Merged
merged 2 commits into from Jan 21, 2024
Merged

Stop using chocolatey shims #6269

merged 2 commits into from Jan 21, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire mentioned this pull request Jan 20, 2024
@greg0ire
Copy link
Member Author

greg0ire commented Jan 20, 2024

Ah there are more failures. Great!

Invoke-WebRequest : Server Error
404 - File or directory not found.
The resource you are looking for might have been removed, had its name changed, or is temporarily unavailable.
At line:26 char:3
+   Invoke-WebRequest $source -OutFile $destination
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand
7z : 
At line:27 char:3
+   7z x -y php_sqlsrv-$($DLLVersion)-$($env:php)-nts-vc15-x64.zip > $n ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
ERROR: The system cannot find the file specified.
php_sqlsrv-5.11.1-7.4-nts-vc15-x64.zip

That directory does not have 5.11.1, although it is advertised here: https://windows.php.net/downloads/pecl/releases/sqlsrv/ 🤔

@SenseException
Copy link
Member

I'm afraid Chocolatey didn't exist back then when I still worked with .NET and can't help here. Which version is in use?

@greg0ire
Copy link
Member Author

greg0ire commented Jan 20, 2024

Oh I think I fixed the Chocolatey issue all right. But there is another, unrelated issue. Before this PR, had an issue with this line:

appveyor-retry cinst --params '""/InstallDir:C:\tools\php""' --ignore-checksums -y php --version 7.4.27

Now it has an issue with this line:

Invoke-WebRequest $source -OutFile $destination

According to the history, the last working build was 8 hours ago.

Looking at the logs, it worked because it reused a cache and did not have to go through the above commands. If that cache takes time to expire, that makes it easier to understand how we can have two issues and not just one.

Let us try using the last version still available on windows.php.net
A better fix should be to switch to
https://github.com/Microsoft/msphpsql, but that will probably require a
deeper rework of the build as it provides DLLs for PHP 8 and up.
@greg0ire
Copy link
Member Author

I pushed a hotfix 🤢

It's ugly but at least we can know if we broke the Windows build or not.

@morozov
Copy link
Member

morozov commented Jan 21, 2024

If by "ugly" you mean that now we have a hard-coded version, it's not the first time we are doing it. See #3484 for reference.

This is totally acceptable.

@derrabus derrabus added this to the 3.7.3 milestone Jan 21, 2024
@derrabus derrabus merged commit ce594cb into doctrine:3.7.x Jan 21, 2024
3 checks passed
derrabus added a commit to derrabus/dbal that referenced this pull request Jan 21, 2024
* 3.7.x:
  Stop using chocolatey shims (doctrine#6269)
@derrabus derrabus mentioned this pull request Jan 21, 2024
@greg0ire greg0ire deleted the choco-depr branch January 21, 2024 08:34
derrabus added a commit to derrabus/dbal that referenced this pull request Jan 25, 2024
* 3.8.x:
  Revert the rename column feature (doctrine#6276)
  fix: TableDiff deprecation points to wrong method (doctrine#6273)
  Stop using chocolatey shims (doctrine#6269)
  Add explicit renameColumn method for Table (doctrine#6080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants