Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warnings when running PHPUnit in CI #6431

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

stof
Copy link
Member

@stof stof commented Jun 7, 2024

Q A
Type improvement
Fixed issues

Summary

As the configuration files are configured to make PHPUnit fail on warning, not displaying them makes it hard to debug failures.
PHPUnit 10 does not show them by default (even when it triggers failures because of them).

As the configuration files are configured to make PHPUnit fail on
warning, not displaying them makes it hard to debug failures.
@stof
Copy link
Member Author

stof commented Jun 7, 2024

I just found that the XML config file supports a displayDetailsOnTestsThatTriggerWarnings setting. This could be used instead of the CLI flag if you prefer.

@stof
Copy link
Member Author

stof commented Jun 7, 2024

this has initially been done as part of #6428 where it was the only way I could figure out why the OCI job was failing...

@derrabus derrabus added this to the 4.0.3 milestone Jun 7, 2024
@derrabus derrabus merged commit 8cb38a3 into doctrine:4.0.x Jun 7, 2024
73 checks passed
@stof stof deleted the display_warnings branch June 10, 2024 09:32
derrabus added a commit that referenced this pull request Jun 14, 2024
* 4.0.x:
  CI: Update MariaDB versions (#6426)
  CI MariaDB: add 11.4, remove 11.0 (#6432)
  Display warnings when running PHPUnit in CI (#6431)
  Fix typo in the portability documentation (#6430)
  Fix MariaDB fetching of default table character-set (#6361) (#6425)
  Fix the portability documentation (#6429)
  Update tests/Platforms/AbstractPlatformTestCase.php
  Update tests/Platforms/AbstractPlatformTestCase.php
  add test
  Fix: Skip type comparison if disableTypeComments is true
derrabus added a commit to derrabus/dbal that referenced this pull request Jun 19, 2024
* 4.1.x: (25 commits)
  Simplify signature of fetchTableOptionsByTable
  Add MariaDb1010Platform for fetchTableOptionsByTable
  PHPUnit 10.5.21 (doctrine#6447)
  Move schema split for SQLite CREATE INDEX only (doctrine#6352)
  PHPStan 1.11.5 (doctrine#6446)
  Default to distinct union queries (doctrine#6439)
  Revert "Merge pull request doctrine#6413 from achterin/bugfix/foreign_key_name_change_detection"
  Add `QueryBuilder` support for `UNION` clause (doctrine#6369)
  CI: Update MariaDB versions (doctrine#6426)
  CI MariaDB: add 11.4, remove 11.0 (doctrine#6432)
  Display warnings when running PHPUnit in CI (doctrine#6431)
  Fix typo in the portability documentation (doctrine#6430)
  Fix MariaDB fetching of default table character-set (doctrine#6361) (doctrine#6425)
  Fix the portability documentation (doctrine#6429)
  Update tests/Platforms/AbstractPlatformTestCase.php
  Update tests/Platforms/AbstractPlatformTestCase.php
  add test
  Fix: Skip type comparison if disableTypeComments is true
  Remove redundant variable (doctrine#6326)
  Fix test names to reflect their actual purpose
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants