Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the $alias parameter in the from method optional #646

Merged
merged 6 commits into from
Aug 1, 2014

Conversation

JeroenDeDauw
Copy link
Contributor

The refactoring commits can be merged first using PR #645

The approach here is the one briefly discussed at #590 and originally suggested by @guilhermeblanco

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-957

We use Jira to track the state of pull requests and the versions they got
included in.

@@ -1087,33 +1087,64 @@ private function getSQLForSelect()
{
$query = 'SELECT ' . implode(', ', $this->sqlParts['select']) . ' FROM ';

$fromClauses = $this->getFromClauses();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This var is used only at line 1092

@Ocramius
Copy link
Member

Ocramius commented Aug 1, 2014

@JeroenDeDauw gets seal of @Ocramius approval and merge. Thanks! :-)

@Ocramius Ocramius self-assigned this Aug 1, 2014
Ocramius added a commit that referenced this pull request Aug 1, 2014
Make the $alias parameter in the `from` method optional
@Ocramius Ocramius merged commit d686e5d into doctrine:master Aug 1, 2014
@JeroenDeDauw JeroenDeDauw deleted the noalias branch August 1, 2014 09:27
@JeroenDeDauw
Copy link
Contributor Author

Where can I find the release notes and the user docs that presumably should be updated now?

@Ocramius
Copy link
Member

Ocramius commented Aug 1, 2014

@JeroenDeDauw I think it should only be added to the documentation, as the change is backwards compatible.

Release notes are generated from jira issues on release.

@JeroenDeDauw
Copy link
Contributor Author

And the docs are at? I spend a few minutes looking and suspect I a managing to read over the relevant link somewhere.

@Ocramius
Copy link
Member

Ocramius commented Aug 1, 2014

There's documentation at
http://doctrine-dbal.readthedocs.org/en/latest/reference/query-builder.html

Files are at
https://github.com/doctrine/dbal/blob/d686e5d911fd7ebb008e11866aa303d46ec05d08/docs/en/reference/query-builder.rst

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 1 August 2014 15:53, Jeroen De Dauw notifications@github.com wrote:

And the docs are at? I spend a few minutes looking and suspect I a
managing to read over the relevant link somewhere.


Reply to this email directly or view it on GitHub
#646 (comment).

@JeroenDeDauw
Copy link
Contributor Author

Ah, it's in the same git repo! >_>

Thanks @Ocramius

JeroenDeDauw added a commit to JeroenDeDauw/dbal that referenced this pull request Aug 1, 2014
Ocramius added a commit that referenced this pull request Aug 1, 2014
Update docs to relfect the changes to QueryBuilder::from made in #646
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants