-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the $alias parameter in the from
method optional
#646
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-957 We use Jira to track the state of pull requests and the versions they got |
@@ -1087,33 +1087,64 @@ private function getSQLForSelect() | |||
{ | |||
$query = 'SELECT ' . implode(', ', $this->sqlParts['select']) . ' FROM '; | |||
|
|||
$fromClauses = $this->getFromClauses(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This var is used only at line 1092
@JeroenDeDauw gets seal of @Ocramius approval and merge. Thanks! :-) |
Make the $alias parameter in the `from` method optional
Where can I find the release notes and the user docs that presumably should be updated now? |
@JeroenDeDauw I think it should only be added to the documentation, as the change is backwards compatible. Release notes are generated from jira issues on release. |
And the docs are at? I spend a few minutes looking and suspect I a managing to read over the relevant link somewhere. |
There's documentation at Files are at Marco Pivetta On 1 August 2014 15:53, Jeroen De Dauw notifications@github.com wrote:
|
Ah, it's in the same git repo! >_> Thanks @Ocramius |
Update docs to relfect the changes to QueryBuilder::from made in #646
The refactoring commits can be merged first using PR #645The approach here is the one briefly discussed at #590 and originally suggested by @guilhermeblanco