Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBAL-1014] Support HHVM mysqli driver #698

Merged
merged 3 commits into from
Oct 20, 2014

Conversation

deeky666
Copy link
Member

Adds support for HHVM's mysqli driver implementation.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1014

We use Jira to track the state of pull requests and the versions they got
included in.

@kimhemsoe
Copy link
Member

Nice, 👍

Should i press the green button ? :D

@Ocramius Ocramius self-assigned this Oct 20, 2014
@Ocramius
Copy link
Member

@kimhemsoe go for it!

@Ocramius Ocramius assigned kimhemsoe and unassigned Ocramius Oct 20, 2014
kimhemsoe added a commit that referenced this pull request Oct 20, 2014
[DBAL-1014] Support HHVM mysqli driver
@kimhemsoe kimhemsoe merged commit 000b5a7 into doctrine:master Oct 20, 2014
@Ocramius
Copy link
Member

@kimhemsoe do you have jira access?

@stof
Copy link
Member

stof commented Oct 20, 2014

Well, I'm not really sure it was ready for merge. The testsuite is segfaulting for this job

@Ocramius
Copy link
Member

@stof where do you see a segfault?

@stof
Copy link
Member

stof commented Oct 20, 2014

In the new job being enabled in this PR: HHVM-nightly + mysqli: https://travis-ci.org/doctrine/dbal/jobs/38482410#L160

@Ocramius
Copy link
Member

@stof no clue why it passes on master then: I just bumped the phpunit version btw.

@stof
Copy link
Member

stof commented Oct 20, 2014

@Ocramius It does not pass either: https://travis-ci.org/doctrine/dbal/jobs/38494282#L153

but a failure on HHVM does not mark the build itself as failed, as we have not yet reached compatibility

@deeky666
Copy link
Member Author

@stof I guess what @Ocramius mean with master is the stable release of HHVM.

@Ocramius
Copy link
Member

Ah, now I see that the job is about hhvm-nightly there. We didn't even
start checking that one so far.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 20 October 2014 15:29, Christophe Coevoet notifications@github.com
wrote:

@Ocramius https://github.com/Ocramius It does not pass either:
https://travis-ci.org/doctrine/dbal/jobs/38494282#L153

but a failure on HHVM does not mark the build itself as failed, as we have
not yet reached compatibility


Reply to this email directly or view it on GitHub
#698 (comment).

@kimhemsoe
Copy link
Member

@Ocramius Yes, why you asking ?

@Ocramius
Copy link
Member

@Ocramius Yes, why you asking ?

Please poke me on IRC about that when you have time (I also need your email contact) :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants