-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBAL-1014] Support HHVM mysqli driver #698
[DBAL-1014] Support HHVM mysqli driver #698
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1014 We use Jira to track the state of pull requests and the versions they got |
Nice, 👍 Should i press the green button ? :D |
@kimhemsoe go for it! |
[DBAL-1014] Support HHVM mysqli driver
@kimhemsoe do you have jira access? |
Well, I'm not really sure it was ready for merge. The testsuite is segfaulting for this job |
@stof where do you see a segfault? |
In the new job being enabled in this PR: HHVM-nightly + mysqli: https://travis-ci.org/doctrine/dbal/jobs/38482410#L160 |
@stof no clue why it passes on master then: I just bumped the phpunit version btw. |
@Ocramius It does not pass either: https://travis-ci.org/doctrine/dbal/jobs/38494282#L153 but a failure on HHVM does not mark the build itself as failed, as we have not yet reached compatibility |
Ah, now I see that the job is about Marco Pivetta On 20 October 2014 15:29, Christophe Coevoet notifications@github.com
|
@Ocramius Yes, why you asking ? |
Please poke me on IRC about that when you have time (I also need your email contact) :-) |
Adds support for HHVM's mysqli driver implementation.