DBAL-1106 Improve schema introspection performance on Oracle #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1106 We use Jira to track the state of pull requests and the versions they got |
|
Looks good, but will only land in |
Ocramius
added a commit
that referenced
this pull request
Jan 4, 2015
…tion-performance [DBAL-1106] Improve schema introspection performance on Oracle
|
Thx. Did not intend to backport it either :) |
Ocramius
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the overall schema introspection performance on Oracle by optimizing some of the
getList*()method SQL queries in the platform.Unfortunately Oracle system views are rather slow, especially when joining tables. Using subqueries can improve the execution time a lot.
Improved queries
(the times have been measured using an exemplary query from the functional test suite)
getListTableForeignKeysSQL(): Down from~2.33sto~0.68sper querygetListTableColumnsSQL(): Down from~0.49sto~0.14sper querygetListTableIndexesSQL(): Down from~0.5sto~0.25sper queryOverall improvement of
OracleSchemaManagerTestfrom~100sto~37.5s.I was quite impressed by the performance improvements :)