Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SET and ENUM types for MySQL and fix issue with schema update tool #774

Closed
wants to merge 1 commit into from

Conversation

dimak08
Copy link

@dimak08 dimak08 commented Jan 14, 2015

Set and Enum data types are one of the most popular. However, addition of these data types in the project creates a problem when updating of the database structure.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1116

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius Ocramius self-assigned this Jan 14, 2015
@Ocramius Ocramius closed this Jan 14, 2015
@Ocramius
Copy link
Member

This won't be implemented, sorry.

We only support portable functionality, and SET and ENUM are, honestly, a mess that we can't deal with in a cross-platform compliant way.

Also see http://stackoverflow.com/a/9057352/347063

@stof
Copy link
Member

stof commented Jan 14, 2015

you should submit them to https://github.com/beberlei/DoctrineExtensions with other MySQL-specific stuffs (not sure whether the repo is still maintained though).

And I'm not sure this will work properly in the schema tool when inspecting enums or when comparing schemas btw

@Ocramius
Copy link
Member

@dimak08 note that this is also a very old feature request that was marked as "won't fix" earlier too: http://www.doctrine-project.org/jira/browse/DBAL-4

@deeky666
Copy link
Member

You could make it a commented type to allow the schema manager to recognize it.

@stof
Copy link
Member

stof commented Jan 14, 2015

@deeky666 no you cannot. You can rely on commented types if you have a Doctrine type for ENUM('foo', 'bar') and a different Doctrine type for ENUM('foo', 'bar', 'baz'). this is precisely what makes the ENUM type so painful

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants