Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectHydrator and ArrayHydrator incorrectly hydrate fields of child classes in a JTI when a field name collides #6303

Closed
fullbl opened this issue Feb 24, 2017 · 2 comments
Closed

ObjectHydrator and ArrayHydrator incorrectly hydrate fields of child classes in a JTI when a field name collides #6303

fullbl opened this issue Feb 24, 2017 · 2 comments
Assignees
@Ocramius
Labels
Bug Duplicate
Milestone
2.6.0

Comments

@fullbl
Copy link
Contributor

fullbl commented Feb 24, 2017

Hi,

I have an entity named A, which is extended on multi table inheritance by B and C.

Both have a property called $user, which is a simple string on B and a simple_array on C.

If I load the object by query builder with the repository of A and get an object of type B, I could get an empty array, even if I'm expecting a string. This is because AbstractHydrator is setting first non null value from all the joined tabled after translating it into php. Null is converted into array in SimpleArrayType convertToPHPValue function.

An easy solution could be to check for the value to be null BEFORE assigning it, as for #5989
@fullbl fullbl mentioned this issue Feb 24, 2017
Closed
@fullbl fullbl closed this as completed Mar 19, 2017
@Ocramius Ocramius self-assigned this Mar 19, 2017
@dengm129
Copy link

#5989

@Ocramius Ocramius added this to the 2.6.0 milestone Aug 19, 2017
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 documenting why the loose comparison is required
7e7921e
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 removing += operator usage on arrays (scary\!), CS (ali…
c503b81 
…gnment)
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 reverting changes to the OrmFunctionalTestCase
aaad25a
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 minor CS fixes in the test code - alignment/formatting
f6ce69f
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 simplified tests, removing references to contract naming
328467c
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 simplified tests, removing references to contract naming
0882b10
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 adding void hints where applicable
2ab363a
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 removing duplicate test details
e18fb66
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 using strict types in the tests
468496b
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 making unnecessary visible fields private
764ab59
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 correcting type mapping. For simple_array, [] == null…
8af6861 
… (which is bullshit), so we use `array` here
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 re-enabling disabled test code data
42d9162
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 removing useless union type usage
b66643d
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 documenting that the discriminator map order is extremely…
4cbcdb7 
… important for this test
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
#6303 #6304 documenting why collisions in field name hydration in STI…
44f2e22 
…/JTI require additional information and checks in the hydration process
Ocramius added a commit that referenced this issue Aug 19, 2017
@Ocramius
Merge branch 'fix/#6303-#6304-check-for-null-discriminator-before-hyd…
a30d8d8 
…rating-inheritance-rows'

Close #6303
Close #6304
ge aborts
@Ocramius
Copy link
Member

Handled in #6304

@Ocramius Ocramius changed the title ObjectHydrator and ArrayHydrator fail on multiple inheritance with empty simpleArray ObjectHydrator and ArrayHydrator incorrectly hydrate fields of child classes in a JTI when a field name collides Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
Bug Duplicate
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Check if the discriminator value is null before converting it and setting into rowData during hydration
3 participants
@Ocramius @fullbl @dengm129