Fix discriminator column defaults #5590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 5, 2016 12:29
…l params type and length have proper defaults.
…atorColumn defaults for type and length. Note: Even though the column definition generated for a discriminator column would eventually default the type to string and length to 255, the docs specify defaults that should be reflected explicitly in the discriminatorColumn mapping.
|
The change is quite subtle, IMO: marked for 2.6.0 only therefore. |
Ocramius
added a commit
that referenced
this pull request
Jan 5, 2016
…defaults Fix discriminator column defaults
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscriminatorColumn mapping generated by all 3 metadata drivers (annot, yml, xml) was lacking length and type when only the name is specified in the mapping. Even though this results in a columnDef that generates a string column of length 255, the mapping for the discriminator column should have those fields set properly, and should be consistent with the behavior when no discriminator column mapping is specified at all.
Adjusted docs to properly reflect that the @DiscriminatorColumn annotation is optional.
Closes: #1601