-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the Getting Started guide's documentation #5677
Conversation
@@ -170,15 +170,10 @@ factory method. | |||
Generating the Database Schema | |||
------------------------------ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The statement "Now that we have defined the Metadata mappings" is not accurate. At this point in the tutorial, we haven't defined any metadata mappings yet.
16f9a39
to
7f280f3
Compare
7f280f3
to
938db45
Compare
@@ -616,12 +613,13 @@ domain model to match the requirements: | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section regarding ArrayCollection seemed to be incorrect, since no objects of type "Doctrine" are involved here. Please confirm the accuracy of the re-write, though.
@Ocramius is there any appetite for these types of changes from the core Doctrine team? I have some improvements to offer for other sections of the tutorial too, but would like some feedback on this one before submitting them. |
There is, but I really didn't manage to track this one before today, sorry :-( Keep 'em coming! I'm merging this one after a manual rebase :-) Thanks for your help! |
Manually merged via b925cce |
This pull request contains a number of individual changes, but they all fall into a few common categories:
In its current state, Doctrine's documentation is already quite fantastic. Yet it could still benefit from a little extra polish. I strongly believe that the modifications contained herein will significantly improve the accuracy and readability of the Getting Started guide. This is obviously an important goal, since the Guide is likely the very first point of contact that many new users will have with Doctrine.