Fix typo #5853
Fix typo #5853
Conversation
| @@ -217,7 +217,7 @@ public function getRegion(array $cache) | |||
|
|
|||
| if ( ! $this->fileLockRegionDirectory) { | |||
| throw new \LogicException( | |||
| 'If you what to use a "READ_WRITE" cache an implementation of "Doctrine\ORM\Cache\ConcurrentRegion" is required, ' . | |||
| 'If you want to use a "READ_WRITE" cache an implementation of "Doctrine\ORM\Cache\ConcurrentRegion" is required, ' . | |||
| 'The default implementation provided by doctrine is "Doctrine\ORM\Cache\Region\FileLockRegion" if you what to use it please provide a valid directory, DefaultCacheFactory#setFileLockRegionDirectory(). ' | |||
There was a problem hiding this comment.
Same typo next line (starting with The default implementation provided by doctrine is...)
|
It seems that you have to fix some tests |
|
Already fixed 😉 |
|
But we have a failing test that is unrelated with this change (only for PHP 7). I will also fix it here... |
|
Actually it just happens on PHP 7.0.7 (cool!) Edit: Digging up the change log I saw that it |
|
The problem here is that As you can see here the @Ocramius how should we tackle this problem? Maybe merging this PR and opening a new issue? |
|
Unrelated failures are not your problem ;-)
|
Nice, I'll create an issue about that bug. Edit: #5854 created |
|
Merged, will go into 2.6.0 only though, as it is not really critical :-) Thanks, @lcobucci! |
|
Nice, is indeed way far from being critical HAHAHA |
No description provided.