Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing type hints, add strictness for some checks, remove some useless calls #5987

Closed
wants to merge 1 commit into from
Closed

Add missing type hints, add strictness for some checks, remove some useless calls #5987

wants to merge 1 commit into from

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Aug 22, 2016 •
edited
Loading

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1126
License MIT
Doc PR n/a

CHANGELOG:

  • Remove calls to strlen(), count(), empty() when the intended behavior can be achieved via type juggling.
  • Add strictness for comparisons where possible.
  • Use Yoda conditions.
  • Add missing type hints.

@phansys phansys changed the title [minor] Add missing type hints, add strictness for some checks at EntityGenerator [minor] Add missing type hints, add strictness for some checks, remove some useless calls Sep 11, 2016
@phansys phansys changed the title [minor] Add missing type hints, add strictness for some checks, remove some useless calls [WIP] [minor] Add missing type hints, add strictness for some checks, remove some useless calls Sep 11, 2016
@Ocramius Ocramius self-assigned this Nov 26, 2016
@Ocramius Ocramius added this to the 2.6.0 milestone Nov 26, 2016
@Ocramius Ocramius changed the title [WIP] [minor] Add missing type hints, add strictness for some checks, remove some useless calls Add missing type hints, add strictness for some checks, remove some useless calls Nov 26, 2016
Ocramius added a commit that referenced this pull request Nov 26, 2016
@Ocramius
#5987 inlined check for boolean 'true' literal
24da906
Ocramius added a commit that referenced this pull request Nov 26, 2016
@Ocramius
#5987 CS: spacing after ! (not) operator
3cd7b8c
@Ocramius Ocramius closed this in a9230b8 Nov 26, 2016
@Ocramius
Copy link
Member

Manually rebased and merged, thanks @phansys!

a9230b8

@phansys phansys deleted the entitygenerator branch December 1, 2016 19:53
@phansys
Copy link
Contributor Author

phansys commented Dec 1, 2016

Thank you @Ocramius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Improvement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phansys @Ocramius