As of HHVM 3.15 pgsql is supported, add php 7.1 to tests #6014
Conversation
photodude
commented
Sep 9, 2016
•
photodude
commented
- Remove the HHVM exclusion now that pgsql is in core HHVM
- add PHP 7.1
- fix the xdebug line that was erroring the php 7.1+ and HHVM builds
Stop testing against old HHVM 3.9 and test against current LTS 3.15
Also Allow HHVM 3.15 with pgsql to fail
|
@Ocramius this is ready for consideration now. |
photodude
changed the title
| include: | ||
| - php: hhvm-3.15 |
There was a problem hiding this comment.
This is painful to maintain, and will require changing every time there is a minor version bump. Can we just rely on hhvm at the base config, and have travis-ci update to latest stable?
There was a problem hiding this comment.
Yes and no...
I chose 3.15 since it's LTS, I believe the next LTS will be 3.18 or 3.20, or maybe 4.0. Considering 3.15 like an LTS php version 5.6 or 7.0
To be on the actual latest of HHVM we can skip specifying the version, but we can't put it in the base configuration since the Trusty container builds on Travis CI have not been released, and the precise containers only support HHVM 3.9. See HHVM options
So it's just a matter of do you only want to test latest, LTS versions, both, etc.
We can also add builds for HHVM in php 7 mode rather than the default php 5 mode. (I skipped that option since HHVM currently has an issue with the PHP 7 mode that is blocking composer from working)
Move sudo: false to the top line to be more clear about use of containers as default vs the trusty builds for HHVM
|
@Ocramius can the MariaDB 5.5 builds be removed? |
|
@photodude yes, we can safely move everything to 5.6+ |
reorder matrix so all HHVM tests are at the bottom
|
Done, ready for review again. |
|
@Ocramius bump for merge consideration |
|
@photodude 👍 thanks for the poke! |
|
You are welcome |
