Remove unused "$className" argument #6216
Conversation
| * @param string $type | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function getSelectJoinColumnSQL($tableAlias, $joinColumnName, $className, $type) | ||
| protected function getSelectJoinColumnSQL($tableAlias, $joinColumnName, $type) |
There was a problem hiding this comment.
This is a minor BC break, and needs to be documented in UPGRADE.md
|
@Ocramius now that I looked at it more deeply, this change can break code on users' side as Still valid or can be closed? |
| @@ -1,5 +1,9 @@ | |||
| # Upgrade to 2.5 | |||
|
|
|||
| ## Minor BC BREAK: remove $className parameter on AbstractEntityInheritancePersister#getSelectJoinColumnSQL | |||
There was a problem hiding this comment.
Put backticks around AbstractEntityInheritancePersister#getSelectJoinColumnSQL
| @@ -1,5 +1,9 @@ | |||
| # Upgrade to 2.5 | |||
|
|
|||
| ## Minor BC BREAK: remove $className parameter on AbstractEntityInheritancePersister#getSelectJoinColumnSQL | |||
|
|
|||
| As `$className` parameter is not used on its method body, it was safely removed. | |||
There was a problem hiding this comment.
s/is not used on its method body/was not used in the method
Persisters are internal API, and we don't support custom userland persisters anyway. This is still valid. |
For v2.6.0, $className argument was removed from `AbstractEntityInheritancePersister#getSelectJoinColumnSQL()` via doctrine#6216. However, the documented minor BC break for upgrading to v2.6 was put under Upgrade to 2.5. This commit fixes this by moving it to v2.6
/cc @Ocramius @lcobucci