Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle AssociationCacheEntry identifier #6217

Closed
wants to merge 1 commit into from
Closed

Handle AssociationCacheEntry identifier #6217

wants to merge 1 commit into from

Conversation

gadelkareem
Copy link
Contributor

Fixes Notice: Undefined property: Doctrine\ORM\Cache\AssociationCacheEntry::$id when retrieving an associated entity from a Composite primary key

@gadelkareem
Handle AssociationCacheEntry identifier
a4d24ea 
Fixes `Notice: Undefined property: Doctrine\ORM\Cache\AssociationCacheEntry::$id`
@Ocramius
Copy link
Member

Ocramius commented Jan 6, 2017

A test is needed

@Ocramius Ocramius self-requested a review January 6, 2017 01:55
@lcobucci lcobucci self-assigned this Jan 12, 2017
@gadelkareem gadelkareem deleted the patch-1 branch February 10, 2017 16:11
gadelkareem added a commit to gadelkareem/doctrine2 that referenced this pull request Feb 10, 2017
@gadelkareem
Add tests for doctrine#6217
5181647
@gadelkareem gadelkareem changed the base branch from 2.5 to master February 10, 2017 16:13
@gadelkareem gadelkareem mentioned this pull request Feb 10, 2017
Closed
@Ocramius Ocramius assigned Ocramius and unassigned lcobucci Feb 10, 2017
lcobucci pushed a commit to gadelkareem/doctrine2 that referenced this pull request Feb 19, 2017
@gadelkareem @lcobucci
Add tests for doctrine#6217
48762bc
lcobucci pushed a commit to gadelkareem/doctrine2 that referenced this pull request Feb 19, 2017
@gadelkareem @lcobucci
Add tests for doctrine#6217
6731689
lcobucci pushed a commit to gadelkareem/doctrine2 that referenced this pull request Feb 19, 2017
@gadelkareem @lcobucci
Add tests for doctrine#6217
7509c16
lcobucci pushed a commit to gadelkareem/doctrine2 that referenced this pull request Feb 19, 2017
@gadelkareem @lcobucci
Add tests for doctrine#6217
17d67f5
Ocramius pushed a commit that referenced this pull request Aug 22, 2017
@gadelkareem @Ocramius
Add tests for #6217
309b286
Ocramius added a commit that referenced this pull request Aug 22, 2017
@Ocramius
#6284 #6217 removing hacks around the ClassMetadata details - inval…
caa008b 
…id fix that was actually fixing the symptom
@Ocramius Ocramius mentioned this pull request Aug 22, 2017
Merged
Ocramius added a commit that referenced this pull request Aug 25, 2017
@Ocramius
#6284 #6217 s/$this->assert/self::assert as per @lcobucci's review
660f164
@Ocramius Ocramius added this to the 2.6.0 milestone Aug 25, 2017
Ocramius added a commit that referenced this pull request Aug 25, 2017
@Ocramius
Merge pull request #6640 from doctrine/fix/#6284-#6217-avoid-passing-…
61404e2 
…l2-cache-information-internals-to-the-uow

#6217 #6284 when hydrating an entity with a composite primary key that is both an `EAGER` and a `LAZY` association and also cached, the `DefaultQueryCache` tries to pass L2 cache implementation detail objects to the `UnitOfWork`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@Ocramius Ocramius

Labels
Bug
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gadelkareem @Ocramius @lcobucci