Improve exception message for DQL single-valued association path expression to an inverse side (unsupported) #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Mar 12, 2017
| * @return QueryException | ||
| */ | ||
| public static function associationPathInverseSideNotSupported() | ||
| public static function associationPathInverseSideNotSupported($pathExpr) |
There was a problem hiding this comment.
I know the caller side uses abbreviations, but please don't abbreviate here.
There was a problem hiding this comment.
I was following this example. Are you fine with the inconsistency?
There was a problem hiding this comment.
If you can add it to the patch, could also rename the variable there please? 👍
| @@ -204,13 +204,15 @@ public static function overwritingJoinConditionsNotYetSupported($assoc) | |||
| } | |||
|
|
|||
| /** | |||
| * @param object $pathExpr | |||
There was a problem hiding this comment.
Is there really nothing more detailed than object? :| Sounds like the SqlWalker internal API could need a DTO
|
And yep, a test for the static method is needed :-\ |
Ocramius
changed the title
Ocramius
added a commit
that referenced
this pull request
Jun 21, 2017
Ocramius
added a commit
that referenced
this pull request
Jun 21, 2017
…meter to the exception named constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added path expression to the exception about single-valued association to an inverse side being not supported. The path expression makes it easier to identify the issue among many other expression in potentially complex query.
Seems like many people had an issue with this exception.
For a query:
The exception message before:
The exception message after: