Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum dependencies #6377

Merged
merged 5 commits into from
Mar 31, 2017
Merged

Conversation

Sam-Burns
Copy link
Contributor

@Sam-Burns Sam-Burns commented Mar 31, 2017

There are lots of PHP projects* where Composer is run with the --prefer-lowest flag as part of a dedicated build. This ensures that the dependency ranges given remain accurate, by testing with dependency versions at the bottom of the specified range.

This PR adds such a build to Doctrine, and corrects the minimum dependencies specified in composer.json, to get the tests to pass.

*Examples: Symfony, PHPUnit, Prophecy, PhpSpec

@Ocramius
Copy link
Member

This is awesome, wanted ti do it sincr a while! Thanks @Sam-Burns!

@Ocramius Ocramius self-assigned this Mar 31, 2017
@Ocramius Ocramius added this to the 2.6.0 milestone Mar 31, 2017
@Ocramius Ocramius merged commit 904f4d5 into doctrine:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants