Fix YAML related tests #6478
Merged
Fix YAML related tests #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had duplicated keys and that's no longer valid on symfony/yaml 3.3.
| @@ -135,7 +135,6 @@ Doctrine\Tests\Models\CMS\CmsUser: | |||
| name: address_id | |||
| referencedColumnName: id | |||
| cascade: [ persist ] | |||
| oneToOne: | |||
There was a problem hiding this comment.
Why is that key removed ?
There was a problem hiding this comment.
It's duplicated and the parser now complains
There was a problem hiding this comment.
seems good to go to me then
| @@ -52,7 +52,6 @@ Doctrine\Tests\Models\Company\CompanyPerson: | |||
| name: address_id | |||
| referencedColumnName: id | |||
| cascade: [ persist ] | |||
| oneToOne: | |||
Ocramius
suggested changes
May 30, 2017
| $flags = 0; | ||
|
|
||
| if (defined(Yaml::class . '::PARSE_KEYS_AS_STRINGS')) { | ||
| $flags = Yaml::PARSE_KEYS_AS_STRINGS; |
There was a problem hiding this comment.
return Yaml::parse(file_get_contents($file), Yaml::PARSE_KEYS_AS_STRINGS);
| $flags = Yaml::PARSE_KEYS_AS_STRINGS; | ||
| } | ||
|
|
||
| return Yaml::parse(file_get_contents($file), $flags); |
There was a problem hiding this comment.
return Yaml::parse(file_get_contents($file), 0);
Since Symfony 3.3 implicit conversion is not enabled by default so we need to pass that flag manually. Related to: symfony/symfony#21774
Ocramius
approved these changes
May 30, 2017
|
@Ocramius fixed, thanks |
|
Green! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony dropped the implicit conversion so we need to do it by ourselves 😉