Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document string as possible parameter type for Expr#between() #6579

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

Nek-
Copy link
Contributor

@Nek- Nek- commented Jul 24, 2017

People may want to enter a date, or simply the parameter name (:param).

Also, linters may report an error while it's a good usage.

People may want to enter a date, or simply the parameter name. Linter may report an error while it's a good usage.
@Ocramius Ocramius self-assigned this Aug 18, 2017
@Ocramius Ocramius added this to the 2.6.0 milestone Aug 18, 2017
@Ocramius
Copy link
Member

LGTM thanks @Nek-!

@Ocramius Ocramius merged commit fda7707 into doctrine:master Aug 18, 2017
@Ocramius Ocramius changed the title Add string type as possible parameter for between Document string as possible parameter type for Expr#between() Aug 18, 2017
@Nek- Nek- deleted the patch-1 branch August 18, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants