Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to NonUniqueResultException #6606

Merged
merged 2 commits into from
Aug 6, 2017

Conversation

lcobucci
Copy link
Member

@lcobucci lcobucci commented Aug 6, 2017

Reopening #1575

@lcobucci lcobucci added this to the 2.6.0 milestone Aug 6, 2017
@lcobucci lcobucci self-assigned this Aug 6, 2017
@lcobucci lcobucci merged commit aa13e49 into doctrine:master Aug 6, 2017
@lcobucci lcobucci deleted the add-exception-msg branch August 6, 2017 10:29
@lcobucci
Copy link
Member Author

lcobucci commented Aug 6, 2017

@Alfredao @jeanCarloMachado 🚢 thanks for you contribution!

@@ -27,4 +27,10 @@
*/
class NonUniqueResultException extends UnexpectedResultException
{
const DEFAULT_MESSAGE = 'More than one result was found for query although one row or none was expected.';

public function __construct(string $message = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ?string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants