Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Query#$_maxResults to allow for null (no limit) #6685

Merged
merged 2 commits into from
Sep 4, 2017
Merged

Updating Query#$_maxResults to allow for null (no limit) #6685

merged 2 commits into from
Sep 4, 2017

Conversation

votemike
Copy link

@votemike votemike commented Sep 4, 2017 •
edited
Loading

I am using PHPStan level 7 in a project I am working on. This pull request means I will be able to remove one of my PHPStan ignore rules.

Ocramius
Ocramius approved these changes Sep 4, 2017
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Sep 4, 2017
@Ocramius Ocramius added this to the 2.6.0 milestone Sep 4, 2017
@Ocramius Ocramius changed the title Updating _maxResults to allow for null Updating Query#$_maxResults to allow for null (no limit) Sep 4, 2017
@Ocramius Ocramius merged commit 8b81691 into doctrine:master Sep 4, 2017
@Ocramius
Copy link
Member

Ocramius commented Sep 4, 2017

Thanks @votemike!

@votemike votemike deleted the update-maxresult-docblocks branch September 4, 2017 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Documentation Improvement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@votemike @Ocramius