Promote nullable types from PHP 7.1 #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't show type hinting in a bad light with sentences such as "If you insist on type-hinting"
Ocramius
suggested changes
Sep 21, 2017
| Also note that if you use type-hinting in your methods, i.e. | ||
| ``setAddress(Address $address)``, you will have to specifically | ||
| allow null values, otherwise ``setAddress(null)`` will fail to | ||
| remove the association. Starting from PHP 7.1 you should use |
There was a problem hiding this comment.
I wouldn't add the detail of PHP 7.1: just the fact that a nullable hint should be used
| allow null values, otherwise ``setAddress(null)`` will fail to | ||
| remove the association. Starting from PHP 7.1 you should use | ||
| nullable types by prefixing the type with a ``?``, | ||
| ``setAddress(?Address $address)``. Older PHP versions will only |
There was a problem hiding this comment.
We really don't care about older PHP versions here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't show type hinting in a bad light with sentences such as "If you insist on type-hinting"