Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

[WIP] Improvements / Refactoring #159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

prolic
Copy link

@prolic prolic commented Jan 30, 2013

This is my first PR to get in touch with doctrine orientdb odm:

  • add EventManager [WIP: make use of it]
  • refactor getRepository method to check for repository class in class meta data [WIP: missing tests]

refactored getRepository method to check for repository class in class meta data
@odino
Copy link
Member

odino commented Jan 31, 2013

totally pro this PR! 👍

What about adding / fixing the tests?

@prolic
Copy link
Author

prolic commented Jan 31, 2013

I am still working on this one. See the title WIP (Work in Progress).

@odino
Copy link
Member

odino commented Jan 31, 2013

sweet!

@odino
Copy link
Member

odino commented May 7, 2013

@nrk this PR looks awesome to me. What do you say, merge it?

@prolic thanks for the effort! :)

@prolic
Copy link
Author

prolic commented May 7, 2013

Sorry for being so late. My initial goal to complete this is way beyond.
Actually, it should be ready to merge, however I would like to make further additions, but that could also be handled in another PR.

@odino
Copy link
Member

odino commented May 7, 2013

@prolic yup, you can go with another PR. Im waiting @nrk's feedback to merge it

@nrk
Copy link
Member

nrk commented May 8, 2013

@odino sorry I won't be able to review @prolic's PR right now until the end of the month, but as far as I remember the last time I checked it seemed OK to me (admittedly I couldn't find the time to test or have a deeper look into the code).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants