Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-3993: [GH-1552] Collection cache key is built differently on read than on write #4854

Closed
doctrinebot opened this issue Nov 11, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@doctrinebot
Copy link

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of guiwoda:

Url: #1552

Message:

This one's a quick bugfix that would be better if we could refactor key building logic inside the \Doctrine\ORM\Cache implementations, but that would be a (albeit small) BC break in its current API.

I intentionally named the refactored protected method exactly as its named in \Doctrine\ORM\DefaultCache.

Testing this proved harder than what it's worth. I'm actually patching this in userland, and you'll find the bug and correction pretty obvious if you look at both the modified class and \Doctrine\ORM\DefaultCache, so I hope we can merge this one and maybe work on a full test suite for all of the Persister strategies.

Cheers!

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1552] was assigned:
#1552

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1552] was merged:
#1552

@doctrinebot
Copy link
Author

Issue was closed with resolution "Fixed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants