You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This one's a quick bugfix that would be better if we could refactor key building logic inside the \Doctrine\ORM\Cache implementations, but that would be a (albeit small) BC break in its current API.
I intentionally named the refactored protected method exactly as its named in \Doctrine\ORM\DefaultCache.
Testing this proved harder than what it's worth. I'm actually patching this in userland, and you'll find the bug and correction pretty obvious if you look at both the modified class and \Doctrine\ORM\DefaultCache, so I hope we can merge this one and maybe work on a full test suite for all of the Persister strategies.
Cheers!
The text was updated successfully, but these errors were encountered:
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of guiwoda:
Url: #1552
Message:
This one's a quick bugfix that would be better if we could refactor key building logic inside the
\Doctrine\ORM\Cache
implementations, but that would be a (albeit small) BC break in its current API.I intentionally named the refactored protected method exactly as its named in
\Doctrine\ORM\DefaultCache
.Testing this proved harder than what it's worth. I'm actually patching this in userland, and you'll find the bug and correction pretty obvious if you look at both the modified class and
\Doctrine\ORM\DefaultCache
, so I hope we can merge this one and maybe work on a full test suite for all of the Persister strategies.Cheers!
The text was updated successfully, but these errors were encountered: