Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite #1289

Merged
merged 4 commits into from Jan 27, 2015
Merged

Improve test suite #1289

merged 4 commits into from Jan 27, 2015

Conversation

deeky666
Copy link
Member

This PR adopts DBAL's latest test suite improvements from doctrine/dbal#597, doctrine/dbal#643, doctrine/dbal#779 and doctrine/dbal#758
Supersedes #1285

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3546

We use Jira to track the state of pull requests and the versions they got
included in.

$GLOBALS['db_password'],
$GLOBALS['db_host'],
$GLOBALS['db_name'],
$GLOBALS['db_port']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, copy-paste :D Will fix.

@Ocramius
Copy link
Member

amaze

@TomasVotruba
Copy link
Contributor

@deeky666 Great job!

@deeky666
Copy link
Member Author

You're welcome. Actually I forgot to bake in doctrine/dbal#779 (doh!). Will do now

@deeky666
Copy link
Member Author

okay now it's finished!

Ocramius added a commit that referenced this pull request Jan 27, 2015
@Ocramius Ocramius merged commit 969788d into doctrine:master Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants