New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the build and the distribution on travis #9

Merged
merged 18 commits into from Oct 27, 2016

Conversation

Projects
None yet
2 participants
@jluis
Contributor

jluis commented Oct 26, 2016

After reading the documentation that @dod38fr pointed me in order to complete my CPAN PRC (isue 8) I tried to build from github and noticed that it wasn't as easy as piping Dist::Zilla output to cpanminus 馃槃

That is the result of my test that shall also help me to update README.build-from-git

I left the history of my commits (are more commits than lines in the .travis.yml file) and the travis tests are on https://travis-ci.org/jluis/config-model

Thanks for you time

@dod38fr

This comment has been minimized.

Show comment
Hide comment
@dod38fr

dod38fr Oct 26, 2016

Owner

That's a very good start 馃憤

To dot the legal "i" and cross the legal "t", could you specify that you're releasing your contributions under the same terms as config-model project (e.g. LGPL-2.1 or later) ? I don't mind you keeping copyright. (it may well be that my Debian developer side is a little bit too picky, but I would be more comfortable with such a statement from you.)

All the best

Owner

dod38fr commented Oct 26, 2016

That's a very good start 馃憤

To dot the legal "i" and cross the legal "t", could you specify that you're releasing your contributions under the same terms as config-model project (e.g. LGPL-2.1 or later) ? I don't mind you keeping copyright. (it may well be that my Debian developer side is a little bit too picky, but I would be more comfortable with such a statement from you.)

All the best

@jluis

This comment has been minimized.

Show comment
Hide comment
@jluis

jluis Oct 27, 2016

Contributor

Sure I release all my PR under the same license that the project I send the pull request to. Also I don't mid giving you the copyright to you.

How I do it? is this statement sufficient to you? I need to put a note on the file? on every pr the PR?

Thanks for your fast feedback.

Contributor

jluis commented Oct 27, 2016

Sure I release all my PR under the same license that the project I send the pull request to. Also I don't mid giving you the copyright to you.

How I do it? is this statement sufficient to you? I need to put a note on the file? on every pr the PR?

Thanks for your fast feedback.

@dod38fr

This comment has been minimized.

Show comment
Hide comment
@dod38fr

dod38fr Oct 27, 2016

Owner

Yes. that's enough. I'm going to merge.

Thanks for your PR :-)

Owner

dod38fr commented Oct 27, 2016

Yes. that's enough. I'm going to merge.

Thanks for your PR :-)

@dod38fr dod38fr merged commit 50b5c3d into dod38fr:master Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment