Test the build and the distribution on travis #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had some problems building the distribution from git so I decided smoke the distribution on Travis to facilitate my work for my October CPAN PRC Signed-off-by: Jose Luis Perez Diez <jluis@escomposlinux.org>
|
That's a very good start 馃憤 To dot the legal "i" and cross the legal "t", could you specify that you're releasing your contributions under the same terms as config-model project (e.g. LGPL-2.1 or later) ? I don't mind you keeping copyright. (it may well be that my Debian developer side is a little bit too picky, but I would be more comfortable with such a statement from you.) All the best |
|
Sure I release all my PR under the same license that the project I send the pull request to. Also I don't mid giving you the copyright to you. How I do it? is this statement sufficient to you? I need to put a note on the file? on every pr the PR? Thanks for your fast feedback. |
|
Yes. that's enough. I'm going to merge. Thanks for your PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading the documentation that @dod38fr pointed me in order to complete my CPAN PRC (isue 8) I tried to build from github and noticed that it wasn't as easy as piping Dist::Zilla output to cpanminus 馃槃
That is the result of my test that shall also help me to update README.build-from-git
I left the history of my commits (are more commits than lines in the .travis.yml file) and the travis tests are on https://travis-ci.org/jluis/config-model
Thanks for you time