Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer does not scale with page #47

Closed
dmouriss opened this issue Aug 1, 2019 · 6 comments
Closed

footer does not scale with page #47

dmouriss opened this issue Aug 1, 2019 · 6 comments
Labels
feature New feature or request migrated Issues migrated from our previous GitHub enterprise repository
Milestone

Comments

@dmouriss
Copy link
Contributor

dmouriss commented Aug 1, 2019

When the content of the page is wider than the viewport, the footer does not span the full with of the page but only the width of the viewport. This can easily be reproduced by adding a wide image to the home page (e.g. https://upload.wikimedia.org/wikipedia/commons/6/6c/Herjangsfjorden_%26_Ofotfjorden,_wide,_2009_09.jpg)

Original issue by @dmouriss on Tue Apr 26 2016 at 14:14.
Closed by @bmesuere on Sat Sep 24 2016 at 10:43.

@bmesuere
Copy link
Member

bmesuere commented Aug 1, 2019

This isn't easy to fix. Is there a real case where this happens?

Original comment by @bmesuere on Wed Apr 27 2016 at 16:45.

@dmouriss
Copy link
Contributor Author

dmouriss commented Aug 1, 2019

It can happen when students play around with the tutor, but maybe I can make it so that the width of the tutor cannot exceed the viewport.

Original comment by @dmouriss on Wed Apr 27 2016 at 16:48.

@dmouriss
Copy link
Contributor Author

dmouriss commented Aug 1, 2019

Keeping the width of the tutor fixed seems impossible. You can not know how big it can get and placing it inside a scroll box does not work since the arrows are manually drawn.

Original comment by @dmouriss on Thu Apr 28 2016 at 17:17.

@bmesuere
Copy link
Member

bmesuere commented Aug 1, 2019

Isn't the tutor inserted by using an iframe? Iframes must have a width and height property and use scroll bars by default.

Original comment by @bmesuere on Thu Apr 28 2016 at 17:45.

@dmouriss
Copy link
Contributor Author

dmouriss commented Aug 1, 2019

the tutor display code is placed inside a div element. If I'm correct, the iframe displayed a page on the opt website, which I tried to avoid.

Original comment by @dmouriss on Mon May 02 2016 at 10:52.

@bmesuere
Copy link
Member

bmesuere commented Aug 1, 2019

no longer relevant

Original comment by @bmesuere on Sat Sep 24 2016 at 10:43.

@dodona-server dodona-server added enhancement migrated Issues migrated from our previous GitHub enterprise repository labels Aug 1, 2019
@bmesuere bmesuere closed this as completed Aug 1, 2019
@bmesuere bmesuere added feature New feature or request and removed enhancement labels Aug 1, 2019
@dodona-server dodona-server modified the milestones: 1.3, 1.1 Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request migrated Issues migrated from our previous GitHub enterprise repository
Projects
None yet
Development

No branches or pull requests

3 participants