Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-forge packaging #6

Closed
bmcfee opened this issue Jun 29, 2022 · 6 comments
Closed

conda-forge packaging #6

bmcfee opened this issue Jun 29, 2022 · 6 comments

Comments

@bmcfee
Copy link

bmcfee commented Jun 29, 2022

👋 @dofuuz are you at all interested in providing a conda-forge package for this library?

libsoxr itself is already available https://anaconda.org/conda-forge/soxr so there shouldn't be any significant barrier here.

The main benefit of conda-forge packaging this library would be ease of installation and management for downstream projects (eg librosa).

@dofuuz
Copy link
Owner

dofuuz commented Jul 2, 2022

conda-forge/staged-recipes#19495
I made PR to conda-forge.

@dofuuz
Copy link
Owner

dofuuz commented Jul 22, 2022

PR for conda-forge is kind of rejected for now.

Actually, python-soxr is using static link for easy installation, so does not need separate libsoxr .
Conda-forge maintainer is requesting (optional) dynamic linking libsoxr. So, it's not likely to be merged into conda-forge for now.

@bmcfee
Copy link
Author

bmcfee commented Aug 5, 2022

Actually, python-soxr is using static link for easy installation, so does not need separate libsoxr .

I followed that discussion over on the conda-forge PR, but I didn't understand why this has to be static only? As noted over there, conda packages are cross-language, so a dynamic linkage here ought to be fine (preferred even). Seems to me like you can have a static build for pypi and a dynamic build for the conda-forge recipe without causing any major trouble.

@dofuuz
Copy link
Owner

dofuuz commented Aug 7, 2022

@bmcfee Yes, that's right. I'm just quite lazy for implement it. 😉
I'll handle this in near future.

@dofuuz
Copy link
Owner

dofuuz commented Aug 19, 2022

Python-SoXR is now on conda-forge. 🎉
https://anaconda.org/conda-forge/soxr-python
https://github.com/conda-forge/soxr-python-feedstock

Note: The Conda package has been named to soxr-python to follow conda-forge's naming scheme.

@bmcfee
Copy link
Author

bmcfee commented Aug 21, 2022

Awesome! 🎉

@bmcfee bmcfee closed this as completed Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants