Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

didHideMenuViewController is never called #62

Closed
1 task done
josipbernat opened this issue May 21, 2019 · 2 comments
Closed
1 task done

didHideMenuViewController is never called #62

josipbernat opened this issue May 21, 2019 · 2 comments

Comments

@josipbernat
Copy link

josipbernat commented May 21, 2019

  • I have verified there are no duplicate active or recent bugs, questions, or requests
Include the following:
  • AKSideMenu version: 1.4.3
  • Device OS version: All versions
  • Device Name: All devices
Reproduction Steps
  1. Set some class (such as left menu view controller) as AKSideMenu delegate
  2. Put breakpoint at func sideMenu(_ sideMenu: AKSideMenu, didHideMenuViewController menuViewController: UIViewController) and write print("hello world") to have written proof that things aren't working.
  3. Open and hide left menu
Expected Result

After hide animation is finished debugger should stop at breakpoint or write in console message that we put inside print() function.

Actual Result

func sideMenu(_ sideMenu: AKSideMenu, willHideMenuViewController menuViewController: UIViewController) is called twice instead once. Investigating in code I saw that inside AKSideMenu.swift (line 442) willHideMenuViewController is called instead of didHideMenuViewController inside completion block.

Tell us what could be improved:

Please call didHideMenuViewController in completion block. If needed I can do thing through pull request.

@dogo
Copy link
Owner

dogo commented May 22, 2019

b174c37
Its already fixed, but not yet released.

@dogo dogo closed this as completed May 22, 2019
@dogo
Copy link
Owner

dogo commented May 22, 2019

Please update to 1.4.4

@dogo dogo reopened this May 22, 2019
@dogo dogo closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants