build: Add check for commit message format #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanstipl
force-pushed
the
check-commits
branch
3 times, most recently
from
b16429c
to
20ba301
Compare
stepanstipl
force-pushed
the
check-commits
branch
from
8303793
to
2010890
Compare
ghost
approved these changes
Oct 29, 2020
|
👍 |
|
we could do this inside a python docker image with commitizen installed instead of bash script, but its a such a minor point. I think this is fine. |
Yep, I was looking at a couple of tools (commitizen, commitlint, conform, go-gitlint), and most of them were missing some config options or it ends-up being regexp anyway, + not a fan of pulling nodejs & all the dependencies. So, in the end, this seemed like the easiest. But agree overall it would be nice to have some good pattern to move this externally... some ideas in #53. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds check and docs for commit message format.