Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing liveness and readiness k8s probes #148

Closed
bygui86 opened this issue May 8, 2024 · 2 comments
Closed

Exposing liveness and readiness k8s probes #148

bygui86 opened this issue May 8, 2024 · 2 comments

Comments

@bygui86
Copy link
Contributor

bygui86 commented May 8, 2024

hi everybody

KubeIP is a great tool, but it lacks one important thing: k8s probes.

What about implementing live- and readiness?

@alexei-led
Copy link
Collaborator

KubeIP works a daemonset and runs only once (replaces IP and does nothing till node shutdown). If K8s had a DaemonJob, I would use it instead.
The liveness probe helps you to understand if service is up an running - not relevant for KubeIP
The readiness probe says that service is ready to accept traffic - also not relevant for KubeIP

@bygui86
Copy link
Contributor Author

bygui86 commented May 10, 2024

hi @alexei-led thanks for your reply.
I agree with you that readiness probe does not make sense, sorry for the proposal.
About liveness probe I was thinking that KubeIP would perform a check every so often, but if it's a one-shot action at the startup then nothing.
I will open another issue to propose an enhancement to have KubeIP perform a checking loop every so often to detect and fix possible drifts.
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants