Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World of Warcraft 1.12: regression caused by 7df8017 #4035

Closed
allfoxwy opened this issue May 28, 2024 · 11 comments · Fixed by #4036
Closed

World of Warcraft 1.12: regression caused by 7df8017 #4035

allfoxwy opened this issue May 28, 2024 · 11 comments · Fixed by #4036
Assignees

Comments

@allfoxwy
Copy link

The 7df8017 commit from yesterday renders all earth in vanilla World of Warcraft 1.12 reflecting: https://youtu.be/FE3w5zxD4_Y

Its parent commit is good.

Software information

World of Warcraft 1.12 vanilla (Turtle server: https://turtle-wow.org/)

System information

  • GPU:
    Firstly witnessed the bug on AMD RX7900XTX on Mesa 24.0.7
    The API trace was made on NVIDIA GeForce MX150 on 551.23 Windows driver (Same bug occur on this platform either)

  • Driver:
    Mesa 24.0.7 with linux-image-6.8.11-1-liquorix-amd64
    NVIDIA 551.23 Windows driver

  • Wine version:
    GE-Proton9-5
    Windows 11 (21H2)

  • DXVK version:
    7df8017

Apitrace file(s)

@K0bin
Copy link
Collaborator

K0bin commented May 28, 2024

Thank you!

@K0bin K0bin self-assigned this May 28, 2024
@K0bin K0bin changed the title 7df8017 is a regression World of Warcraft 1.12: regression caused by 7df8017 May 28, 2024
@K0bin
Copy link
Collaborator

K0bin commented May 28, 2024

image
Oh, I see.

@Tiagoquix
Copy link
Contributor

FYI, API trace file is not public:

image

@K0bin
Copy link
Collaborator

K0bin commented May 28, 2024

It was earlier, I was able to download it.

@allfoxwy
Copy link
Author

FYI, API trace file is not public:

I deleted it earlier, cause its a online game, i kind of worry security.

@7AllenWalker7
Copy link

7AllenWalker7 commented May 29, 2024

I think my issue have same reason.
Wow 3.3.5a, dx 9 x32
7df8017 this version does not display some effects, such as highlighting the object selected in the target or highlighting the place of activation of the puddle at the death knight

c981526 and 890ad3f work good

Снимок экрана 2024-05-29 103322
Снимок экрана 2024-05-29 103050

Nvidia 4070 Super
Windwos 10
Driver 555.85

@emv33
Copy link

emv33 commented May 31, 2024

Seconding the previous comment, if you play the 3.3.5 version of WoW, that happens. I have a hardware setup that is similar to that user's. If an apitrace is needed I can help.

@Blisto91
Copy link
Contributor

Blisto91 commented May 31, 2024

It is already being fixed #4036

Edit: You can try to verify with the version downloaded from here https://github.com/doitsujin/dxvk/actions/runs/9270504936

@7AllenWalker7
Copy link

Yes, it's fixed on #4036
Confirm.

@7AllenWalker7
Copy link

yeah, so it's improve, but performance regressions. Anybody can check this?

@K0bin
Copy link
Collaborator

K0bin commented Jun 2, 2024

Not until you make a proper bug report. I'm not aware of any performance regression and old WOW is almost certainly CPU limited on most systems anyway, so the changes should make no difference at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants